summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOrestis <orestisf1993@gmail.com>2018-10-07 21:26:24 +0300
committerMichael Stapelberg <stapelberg@users.noreply.github.com>2018-10-07 20:26:24 +0200
commit494efd49a26ed96d7b0d3d4f69099ccd83e2ccba (patch)
tree8528ff82b198c81ce970ef87301d8a649e3cd0ea
parent5c9d12befa760e8c7790219f79de837feb5d8ff0 (diff)
strncpy + strlen is pointless (#312)
strlen already assumes that the string is NULL-terminated. Fixes -Wstringop-overflow warning
-rw-r--r--i3status.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/i3status.c b/i3status.c
index 76cb280..b83b1f3 100644
--- a/i3status.c
+++ b/i3status.c
@@ -227,9 +227,10 @@ static char *resolve_tilde(const char *path) {
} else {
head = globbuf.gl_pathv[0];
result = scalloc(strlen(head) + (tail ? strlen(tail) : 0) + 1);
- strncpy(result, head, strlen(head));
- if (tail)
- strncat(result, tail, strlen(tail));
+ strcpy(result, head);
+ if (tail) {
+ strcat(result, tail);
+ }
}
globfree(&globbuf);