diff options
| author | Michael Stapelberg <michael@stapelberg.de> | 2019-07-29 20:57:48 +0200 |
|---|---|---|
| committer | Michael Stapelberg <michael@stapelberg.de> | 2019-07-29 21:07:40 +0200 |
| commit | 23da59920c4c911ee08498eb283b69bdef80fd65 (patch) | |
| tree | 59a9a8bac909e243eabdb2c58e48ec8e5c79f566 /src | |
| parent | 40aeb7bc44aa0fc8373acb8b57debb1c285e7009 (diff) | |
make pulseaudio an optional dependency, follow best practices
For my thoughts about optional dependencies, see
https://michael.stapelberg.ch/posts/2019-05-23-optional-dependencies/
This commit follows the best practices outlined in that article:
1. The travis config was modified to verify both code paths build and link/don’t
link against pulseaudio.
2. If pulseaudio is missing, the build fails until packagers explicitly pass a
--disable flag. In practice, I think the only situation when this flag should
be set is in source-based linux distributions where users can express
package-level compilation preferences (e.g. Gentoo USE flags).
3. The --version output now reflects the status of the optional dependency.
fixes #359
Diffstat (limited to 'src')
| -rw-r--r-- | src/print_volume.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/print_volume.c b/src/print_volume.c index 91e8ce2..7364d47 100644 --- a/src/print_volume.c +++ b/src/print_volume.c @@ -86,7 +86,7 @@ void print_volume(yajl_gen json_gen, char *buffer, const char *fmt, const char * free(instance); } -#if !defined(__DragonFly__) && !defined(__OpenBSD__) +#if HAS_PULSEAUDIO /* Try PulseAudio first */ /* If the device name has the format "pulse[:N]" where N is the |